search

dyoo / WeScheme

29 stars 16 forks source link

The view.jsp doesn't do enough validation on inputs, or is too difficult to share #38

Closed dyoo closed 11 years ago

dyoo commented 12 years ago

Looking at the exceptions happening with regards to view.jsp, I see a lot of misspelled and manually-typed in URLs, like:

GET /view?publicld=fiber-empty-aside-quite-pause

where it's an "Ld" instead of an "id", or:

GET /view?publicid=fiber-empty-aside-quite-pause

where the 'i' is not upper cased. In any event, we generate a scary looking error message, which is not the right thing to do. We should probably change the id lookup mechanism so it's less prone to errors. Maybe something like:

/view?id=...

since you can only view a program via its public id anyway, so why not just shorten the parameter name to something less difficult to type?

dyoo commented 12 years ago

Preserve existing URLs, of course, but make new URLs use a simpler url scheme.