dyphire / mpv-scripts

userscripts for mpv
MIT License
55 stars 5 forks source link

the absence of a comma and a space between the codec and the track language in track-menu.lua #1

Closed AdventurerRussia closed 1 year ago

AdventurerRussia commented 1 year ago

I noticed that there is no comma between the language and the codec of the track, although other data is separated by a comma, my inner perfectionist is indignant. is it still possible to add a path mapping to external files?

image I wanted to ask if it is possible to change the colors of these elements? I didn't find the settings to change them image and what are these functions? [%cursor%/%total%] does it look broken? image

about fix-avsync.lua the script works, but when you switch the track, the sound creaks, breaks for half a second, is it possible to fix it, for example, by silencing the track for 1 second between switching?

about open_dialog.lua is it possible to make it so that by selecting an external track, it immediately becomes the default in the player?

dyphire commented 1 year ago

about fix-avsync.lua the script works, but when you switch the track, the sound creaks, breaks for half a second, is it possible to fix it, for example, by silencing the track for 1 second between switching? about open_dialog.lua is it possible to make it so that by selecting an external track, it immediately becomes the default in the player?

It has been implemented in the latest commit, please test whether it works for you.

and what are these functions? [%cursor%/%total%] does it look broken?

It works fine on my end, make sure you are using the latest script of adevice-list.lua and scroll-list.lua. image

dyphire commented 1 year ago

I noticed that there is no comma between the language and the codec of the track, although other data is separated by a comma, my inner perfectionist is indignant.

~The codec is a special property, so I won't choose to separate it with a comma. I added a commit to separate it with a space, which is also the behavior of mpc-hc.~

Edit: Done it.

is it still possible to add a path mapping to external files?

I didn't understand what you were trying to say.

I wanted to ask if it is possible to change the colors of these elements? I didn't find the settings to change them.

This is possible, refer to scroll-list.lua. But at present, I have no plan to implement it.

AdventurerRussia commented 1 year ago

well, for example, an external track, and so that the path to it is displayed in the system, image something like this This is possible, refer to scroll-list.lua. okay thanks

dyphire commented 1 year ago

well, for example, an external track, and so that the path to it is displayed in the system, something like this image

Now I understand your request, but I won't implemente it. Because too long string will cause unreadable and the osd overflow. In order to avoid too long strings as much as possible, I have tried to split the filename in the tracktitle. https://github.com/dyphire/mpv-scripts/blob/fc04cabb722fff01cce1fa0d5a4f40b23307e556/track-list.lua#L202-L205 Implementing the functions you require will undermine my previous efforts.

AdventurerRussia commented 1 year ago

well, for example, an external track, and so that the path to it is displayed in the system, something like this image

Now I understand your request, but I won't implemente it. Because too long string will cause unreadable and the osd overflow. In order to avoid too long strings as much as possible, I have tried to split the filename in the tracktitle.

https://github.com/dyphire/mpv-scripts/blob/fc04cabb722fff01cce1fa0d5a4f40b23307e556/track-list.lua#L202-L205

Implementing the functions you require will undermine my previous efforts.

thank you again very much for your work and for answering my questions, my requests should not be entered into the main code, these are just my preferences, but thank you again for pointing out how to do what I need.