dyphire / mpv-scripts

userscripts for mpv
MIT License
53 stars 5 forks source link

chapter-make-read.lua - Fails with realistic amount and names for chapters - Works with minimal chapter file #14

Closed porg closed 1 year ago

porg commented 1 year ago

Reproduction

  1. Installed chapter-make-read.lua by moving it into ~/.config/mpv/scripts/
  2. Put sidecar chapter file next to video file:
    • EVM.m4v (49m 28s, no chapters in metadata)
    • EVM.m4v.chp (UTF-8, created with TextEdit)

Result: Chapter loading ✅ works from very minimal but unrealistic chapter file ❌ but fails with realistic chapter file.

✅ Very minimal but unrealistic chapter file

❌ My realistic chapter file

Investigation

Environment

Attachments

Notes

Files

dyphire commented 1 year ago

Fix by commit https://github.com/dyphire/mpv-scripts/commit/bc6763e87f3da0467caf12709b5dde85988f8f18, please test whether it works for you.

porg commented 1 year ago