dyphire / mpv-scripts

userscripts for mpv
MIT License
68 stars 5 forks source link

Chapter files whose name contains a colon don't work with `chapter-make-read.lua` #32

Closed agreselin closed 1 month ago

agreselin commented 1 month ago

Hi, I've noticed that if a filename contains colons then it doesn't work work with chapter-make-read.lua. E.g. I have Megadeth: Tiny Desk Concert.mkv and Megadeth: Tiny Desk Concert.chp. chapter-make-read.lua ignores the chapters until I rename both files replacing the colon with something else. Is it something that can be fixed in the script?

dyphire commented 1 month ago

On Windows, special characters such as \/:? are illegal characters that cannot be used in filenames. This was specially handled in the previous code. Unexpectedly broken usage on Unix platforms, fixed.

agreselin commented 1 month ago

Great, thanks!