dysath / seat-fitting

A Fitting/Doctrine module for SeAT
GNU General Public License v2.0
14 stars 22 forks source link

Fittings show in wrong slot #12

Closed ghost closed 6 years ago

ghost commented 6 years ago

When looking at a fit it seems to be shiffted one slot up or down. As seen here image This is the EFT for the above:

[Vexor Navy Issue, Hordes and patrols] Damage Control II Omnidirectional Tracking Enhancer II Drone Damage Amplifier II Drone Damage Amplifier II Drone Damage Amplifier II Drone Damage Amplifier II

Republic Fleet Large Cap Battery Adaptive Invulnerability Field II Large Shield Booster II 10MN Afterburner II

Medium Anti-EM Screen Reinforcer II Medium Capacitor Control Circuit II Medium Capacitor Control Circuit II

Praetor II x5 Acolyte II x5 Infiltrator II x5

I'm using 3.0.0-alpha6

dysath commented 6 years ago

Ah, no high-slot items.

EFT is not the greatest at keeping things sorted since there's not a real "standard" to it. I might have to propose one.

Put an extra blank space between 10MN AfterburnerII and Medium Anti-EM Screen Reinforcer II

It doesn't know there's no high slot items otherwise.

On Tue, May 15, 2018 at 6:19 PM, Busterguy notifications@github.com wrote:

When looking at a fit it seems to be shiffted one slop up or down. As seen here [image: image] https://user-images.githubusercontent.com/5047710/40088355-93d67080-589e-11e8-84a1-ce75edb63dab.png This is the EFT for the above: `[Vexor Navy Issue, Hordes and patrols] Damage Control II Omnidirectional Tracking Enhancer II Drone Damage Amplifier II Drone Damage Amplifier II Drone Damage Amplifier II Drone Damage Amplifier II

Republic Fleet Large Cap Battery Adaptive Invulnerability Field II Large Shield Booster II 10MN Afterburner II

Medium Anti-EM Screen Reinforcer II Medium Capacitor Control Circuit II Medium Capacitor Control Circuit II

Praetor II x5 Acolyte II x5 Infiltrator II x5`

I'm using 3.0.0-alpha6

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/dysath/seat-fitting/issues/12, or mute the thread https://github.com/notifications/unsubscribe-auth/AQF4jNYaiql5YJMiRBn5QJZNhfky2m5nks5ty2JogaJpZM4UAarT .

-- Ed Stafford

dysath commented 6 years ago

Ok, I found a logic bug and hopefully have squashed it that fixes this issue.

Run a 'composer update' to get the new version