search

dysath / seat-fitting

A Fitting/Doctrine module for SeAT
GNU General Public License v2.0
14 stars 21 forks source link

HTML Syntax Issues in src/resources/views/fitting.blade.php #72

Closed sportshead closed 3 years ago

sportshead commented 3 years ago

There are two HTML issues on the fitting page. https://github.com/dysath/seat-fitting/blob/dcb78f0327082f0d1cc0211e310010b381480d07/src/resources/views/fitting.blade.php#L37 This shouldn't be using ids, as they are repeated. They should be using class instead.

https://github.com/dysath/seat-fitting/blob/dcb78f0327082f0d1cc0211e310010b381480d07/src/resources/views/fitting.blade.php#L122 This is invalid HTML, I assume you meant <input type="hidden" id="fittingId" value="" />? Firefox attempts to "fix" it by rendering this: image

These should theoretically be quite easy to fix.

warlof commented 3 years ago

sounds like to be a good first issue, why not trying to send a pull request including the change? 😊