dyslexic-charactersheets / lib-charactersheets

lib-charactersheets
https://www.dyslexic-charactersheets.com
Artistic License 2.0
22 stars 8 forks source link

[pathfinder 2e] Choosing an action applies to all actions in all #24

Closed bushvin closed 8 months ago

bushvin commented 1 year ago

When selecting how many actions an activity takes causes all icons on the same page to become the selected type.

How to reproduce:

  1. Create a Pathfinder 2e character sheet with additional actions
  2. Go to the page containing Actions (Actions, Skill Actions, Focus Actions)
  3. Click any action icon and select an activity.

All icons in Actions, Skill Actions, Focus Actions are changed to the selected activity.

Tested with Barbarian, Magus and Sorcerer character sheet.

marcus-downing commented 1 year ago

I thought I already fixed this one a few weeks ago. Is it still a problem now?

bushvin commented 1 year ago

I created 2 new characters just yesterday.

maybe you didn’t push from github to your website?

marcus-downing commented 1 year ago

It seems fine to me. Can you send me the file?

bushvin commented 1 year ago

Here you go: link

marcus-downing commented 1 year ago

I'm very confused. That file works fine for me. I select an action, it changes that action.

What browser are you using? Can you pull up the inspector / dev tools (probably F12) and see if anything appears in the console? If all else fails, would you be willing to jump on a Discord or Zoom call to debug this together?

bushvin commented 1 year ago

Apologies for my late response.

I have shared a folder for your convenience: https://wolk.elaba.net/s/GbbNZGg9yDaRcgQ

There is a screencast for both firefox and chromium and the html which I used to generate the screencast. the html was generated after raising this issue here.

I am experiencing the same issue running Firefox 110.0 (daily driver) and Chromium 111.0.5563.64 (backup)

Something does happen when clicking the action icon, but not the first time. From the second time on it throws the below error:

Uncaught TypeError: document.getElementById(...) is null
    showActionMenu file:///home/XXXXXXXXXX/Abbaccus/Abbaccus, Sorcerer.html:3079
    EventListener.handleEvent* file:///home/XXXXXXXXXX/Abbaccus/Abbaccus, Sorcerer.html:3128
[Abbaccus, Sorcerer.html:3079:12](file:///home/XXXXXXXXXX/Abbaccus/Abbaccus,%20Sorcerer.html)
    showActionMenu file:///home/XXXXXXXXXX/Abbaccus/Abbaccus, Sorcerer.html:3079
    (Async: EventListener.handleEvent)
    <anonymous> file:///home/XXXXXXXXXX/Abbaccus/Abbaccus, Sorcerer.html:3128

I've also included a screencast for this on firefox.

Let me know if you would like more. discord or zoom is fine, my timezone is GMT+1, which isn't too far off yours, if I'm correct.

marcus-downing commented 1 year ago

I think I see the confusion. I didn't realise you were looking at the Actions page, so I was clicking the actions on the Character and Combat pages (skill actions, focus actions etc) and they all worked.

marcus-downing commented 1 year ago

You did say that. I just failed to read it.

marcus-downing commented 1 year ago

Hello, I believe the fix for this is live now. Can you confirm if it's fixed?