search

dyson / dokku-persistent-storage

Basic persistent storage for dokku (https://github.com/progrium/dokku)
MIT License
53 stars 12 forks source link

only mount docker volumes on deploy #12

Closed michaelshobbs closed 9 years ago

michaelshobbs commented 9 years ago

Apologies for the other PR. Accidentally opened from my master branch.

A few days ago dokku added running dokku-args plugins for the build phase. This seems to have caused an issue with (at least) heroku-buildpack-python. (ref: progrium/dokku#906)

Additionally, dokku now calls docker-args plugins with a build phase passed as an argument. See: https://github.com/progrium/dokku/blob/fb3492c8242521dec4ed8428983ea752db710f86/dokku#L87

This patch will only mount volumes if we get the deploy call. This is tested in my previously broken environments.

This seems to also cause an issue later on in the pipeline with /build/builder: https://github.com/progrium/buildstep/blob/091eafdad7ccf5f4584aa21704397fd1dc1fd208/builder/builder#L70

michaelshobbs commented 9 years ago

@dyson ping. thoughts on this?

dyson commented 9 years ago

Awesome thanks for this. I'll be deploying a new site using an updated dokku this weekend so will have a close look at this and see what issues I run into.

This will have implications for my https://github.com/dyson/dokku-docker-options plugin as well.