search

dyson / dokku-persistent-storage

Basic persistent storage for dokku (https://github.com/progrium/dokku)
MIT License
53 stars 12 forks source link

Interaction with other `docker-args` pluginhooks #5

Closed martin-hewitt closed 10 years ago

martin-hewitt commented 10 years ago

I've just been debugging an issue with the link plugin: https://github.com/rlaneve/dokku-link/issues/3 and have narrowed the cause down to the link plugin being executed before the persisten-storage plugin. Removing the persistent-storage plugin causes the link plugin to perform as expected.

However, I also have a dokku instance running that uses both the link plugin and the persistent-storage plugin, which loads fine.

This interaction is leading me to wonder whether the persistent-storage plugin should echo out what it receives (echo "$STDIN$output"), regardless of whether it edits it or not?

martin-hewitt commented 10 years ago

Have confirmed an identical issue with the link plugin, hence the PR linked above.

dyson commented 10 years ago

Thanks again, I have merged.