search

dysonance / Strategems.jl

Quantitative systematic trading strategy development and backtesting in Julia
Other
163 stars 39 forks source link

DRY #4

Closed femtotrader closed 6 years ago

femtotrader commented 6 years ago

https://en.wikipedia.org/wiki/Don%27t_repeat_yourself

codecov-io commented 6 years ago

Codecov Report

Merging #4 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #4   +/-   ##
=======================================
  Coverage   78.04%   78.04%           
=======================================
  Files          11       11           
  Lines         164      164           
=======================================
  Hits          128      128           
  Misses         36       36

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a6e0afc...d74ae31. Read the comment docs.

dysonance commented 6 years ago

Haha thanks @femtotrader, I copy/pasted that example in pretty quick and obviously didn't do the proper double-checking. Thanks for having my back man 👊

femtotrader commented 6 years ago

Thanks @dysonance for granting me push access I've just send a commit to fix a similar issue https://github.com/dysonance/Strategems.jl/commit/df85e5a322853a6833d1b3f6018bcfa062019092