search

dysonance / Temporal.jl

Time series implementation for the Julia language focused on efficiency and flexibility
Other
100 stars 26 forks source link

Move data reader out of Temporal #21

Open femtotrader opened 6 years ago

femtotrader commented 6 years ago

Hello,

I wonder if data readers should really be part of Temporal. Related issue https://github.com/dysonance/Temporal.jl/issues/19

Kind regards

femtotrader commented 6 years ago

Quandl, Google Finance, and Yahoo Finance data readers are also concerned

see https://github.com/dysonance/Indicators.jl/issues/7#issuecomment-355082312

dysonance commented 6 years ago

@femtotrader I don't necessarily disagree with you on this point from a best practices standpoint. The reason I originally undertook the effort to do all this was really that Temporal was a package that was not very widely used, and as such there are more difficulties maintaining this support in other more general packages.

Currently I still feel that Temporal isn't popular enough that maintaining support for the TS type would be any kind of major concern for other package developers. This is my personal assessment, feel free to disagree. I also don't see much of a disadvantage in having it supported within this package -- might it be causing some headaches that I'm not aware of?