Closed femtotrader closed 6 years ago
Merging #30 into master will decrease coverage by
29.94%
. The diff coverage is85.71%
.
@@ Coverage Diff @@
## master #30 +/- ##
===========================================
- Coverage 87.41% 57.47% -29.95%
===========================================
Files 13 14 +1
Lines 620 983 +363
===========================================
+ Hits 542 565 +23
- Misses 78 418 +340
Impacted Files | Coverage Δ | |
---|---|---|
src/ts.jl | 77.08% <85.71%> (-22.92%) |
:arrow_down: |
src/io.jl | 12.9% <0%> (-71.31%) |
:arrow_down: |
src/models.jl | 50% <0%> (-35%) |
:arrow_down: |
src/collapse.jl | 64.78% <0%> (-33.09%) |
:arrow_down: |
src/utils.jl | 55.17% <0%> (-29.04%) |
:arrow_down: |
src/show.jl | 57.44% <0%> (-26.43%) |
:arrow_down: |
src/operations.jl | 61.24% <0%> (-24.63%) |
:arrow_down: |
src/slice.jl | 69.31% <0%> (-21.73%) |
:arrow_down: |
src/indexing/stringrange.jl | 67.77% <0%> (-18.28%) |
:arrow_down: |
... and 4 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 8ebef6b...87e403d. Read the comment docs.
odd codecov decrease!
Awesome, thanks for the contribution @femtotrader! It seems like the coverage issue linked by @iblis17 is something a lot of people are experiencing and the devs are aware of it and working on it, so I don't see that being a blocker to merge this. Thanks again for the help guys.
I think we should continue the discussion we started https://github.com/JuliaQuant/MarketTechnicals.jl/issues/93
Closes #22 Closes #23 Should help #20