search

dysonance / Temporal.jl

Time series implementation for the Julia language focused on efficiency and flexibility
Other
100 stars 26 forks source link

bump RecipesBase.jl version #43

Closed Moelf closed 4 years ago

Moelf commented 4 years ago

tests still pass, tested on Julia 1.5;

I think at some point we should just remove Manifest.toml, but for now I don't want to break too many things.

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 78.253% when pulling 4ed1fa53e61a8e8ca121d3537f03f65390be2024 on Moelf:master into dedd46b50f724b19f4ad0910eb90563938d906a2 on dysonance:master.

Moelf commented 4 years ago

ok looks like builds and tests pass when Manifest is removed

dysonance commented 4 years ago

@Moelf Doesn't running Pkg.resolve automatically re-create the manifest? I don't know about the implications that the Julia package manager would have for deleting the Manifest.toml file. How does that affect dependencies and the like? Could it cause problems for people trying to add/install the package later on? If not, it would probably be wise to add the manifest to the .gitignore so that it doesn't keep getting tracked by git.

Moelf commented 4 years ago

yes, you're correct forgot to add that; Deleting Manifest allows pkg to resolve with more flexibility wherares Manifest would pin to exact version -> an exact reproducible environment. I think the standard now is to not have it: e.g https://github.com/JuliaWeb/HTTP.jl https://github.com/JuliaData/CSV.jl