Modular plugins?

[dysproseum]

Insert modules

• needs settings page

Includes their functions Create extension hooks:

• head css/js includes
• directory listing
• file listing line
• stream endpoint

foreach (glob(modules/*.php) include module.info;
if (enabled) include module/module.php

Examples:

• html5audio player
  • flac stream
  • playlist
• mobile layout
  • mobile html5audio
• webamp player

[dysproseum]

{modules:
- iframe,
- mobile_layout,
- html5player:
  - dependencies:
    - iframe
- webamp:
  - dependencies:
    - iframe
- flac stream:
  - dependencies:
    - html5player
}

but these are all interconnected through css; the players have to support if mobile is enabled, and have to work closely with iframe, and the alternate stream actions could be used outside of html5player. so should they be modules or be part of core?

[dysproseum]

the modules could either be optional features like: if (file_exists(custom/module.php)) include custom/module.php;

or they could load them dynamically like above: foreach (glob(modules/*.php) include module.info;

but then it would mean more defined hooks and interface vs. placing the methods where they are needed.

[dysproseum]

for the best experience, the player should probably move to a dropdown instead of multiple checkboxes.

and iframe layout and mobile layout could stay as either/both options.

could either be:

1. mobile and no custom player
2. mobile and custom player (enables iframe)
3. no mobile and no custom player
4. no mobile and custom player (enables iframe)

also mobile css should be overriding stock css, not external.js.

[dysproseum]

The player really could be a user preference too.

Like there is for themes, and there is a theme loader at the top of the file too.

[dysproseum]

This work is in progress in #14

Players were taken out of core and put into themes.

Mobile.css is staying in core, and the themes can add their own mobile.css extensions if needed.

[dysproseum]

Few issues:

• CSS from themes can't be included in the Randomizer window, so this needs external.js to be able to work.
• Last streams loading via ajax needs another method to alter its links since they are refreshed every 5 seconds.

[dysproseum]

https://stackoverflow.com/questions/38334779/how-to-call-function-of-another-iframe

Parent page (iframe.php) - stores childCollection of callbacks

• Child page (player.php) - defines playerFrame and calls parent.registerChild
• Child page (index.php) - gets callbacks and calls them with tracks