search

dytcodetogether / gdidayton

Website for Girl Develop It Dayton
3 stars 19 forks source link

Fix hero image/header responsive views #94

Closed k80bowman closed 5 years ago

k80bowman commented 6 years ago

600px: image

679px: image

900px: image

zastrow commented 5 years ago

I’ll pick this one up.

kcjonesevans commented 5 years ago

@zastrow we are in the process of a Nation rebranding. The new tagline will be "Code, Confidence and Community". I'd appreciate any creative changes to the hero image using the new phrase.

zastrow commented 5 years ago

@kcjonesevans Can Do! Seems like the biggest problem with this particular issue the navigation on certain screen sizes, so that’ll be my primary focus first. On other pages at that 679px screen size the navigation is white text on a white background.

Then the tagline needs some adjustments to keep it from breaking down like it does. I will add in the new text though.

kcjonesevans commented 5 years ago

I noticed the navigation scss/media query was a bit weird myself when I was fixing the hover in another issue https://github.com/gdidayton/gdidayton/pull/111