search

dyve-agency / questionizer

2 stars 0 forks source link

Product host url option is hardcoded #2

Open fsainz opened 9 years ago

fsainz commented 9 years ago

https://github.com/ZEITIO/questionizer/blob/master/config/initializers/smtp_and_url_options.rb#L4

What is the approach here? we could do yet another .example.rb, we could add it to secrets.yml, we could create another configuration file for non secret options...

ariera commented 9 years ago

I don’t see a problem leaving it there. Is it being used somewhere else? Or is the domain of the app in production going to change somehow often?

I once saw a guy using I18n for config options. It is kind of convenient (but also very misleading) you just add a config.yml file in your locales dir and the you can do I18n.t(‘production.host’) :dancer: XDD