[partial][common] log - Githubissues

dyweb / Ayi

Ayi organizes your workspace

MIT License

11 stars 2 forks source link

[partial][common] log #60

Closed at15 closed 7 years ago

at15 commented 7 years ago

Related #59

It is basic a clone of logrus with the following modification

[x] fatal level has lower number than painc level (reversed in logrus)
[x] remove all the Debug, Warn in Logger, only keep those methods on Entry
field value can only be string, logrus use interface{}
didn't use lock (though there is a mutex in Logger)
does not support hook, only have filter
does not trim \n for *f functions
[x] add syntax sugar to create entry with pkg i.e. logger.NewEntryWithPkg("x.tsdb.kairosdb")

the more detail description can be found in README, all the logrus usage are replaced with common/log, and since WithField is not supported, it is replaced by *f....

arrowrowe commented 7 years ago

Hey maybe you would like this: https://about.pullapprove.com/

always_pending:
  title_regex: 'WIP'
  explanation: 'Work in progress...'

at15 commented 7 years ago

@arrowrowe hey maybe I should put mie on fire and brush some oil @mingo-x

arrowrowe commented 7 years ago

@at15 you didn't set the wip rule...

coveralls commented 7 years ago

Coverage increased (+1.7%) to 59.208% when pulling 1a07fe9fe735dcbde141ffb92a59a4056f9aa298 on common-util/log into 06745844e13ae380bf5688ee296828ffaaf5c94a on master.

coveralls commented 7 years ago

Coverage decreased (-2.2%) to 55.316% when pulling b2bfbb3bc60c5c437a8b56a1601ce8f438e9179d on common-util/log into 06745844e13ae380bf5688ee296828ffaaf5c94a on master.

coveralls commented 7 years ago

Coverage increased (+1.0%) to 58.488% when pulling 35de1ad4a1c68fdc32b76c9dbffa24e957a57ed1 on common-util/log into 06745844e13ae380bf5688ee296828ffaaf5c94a on master.

coveralls commented 7 years ago

Coverage increased (+1.0%) to 58.488% when pulling 0ef00656af7d96e32aa4e5a300275ae6bf535376 on common-util/log into 06745844e13ae380bf5688ee296828ffaaf5c94a on master.

coveralls commented 7 years ago

Coverage increased (+1.5%) to 58.989% when pulling c611a4cbd63222e6270f29ade8d9cf3427a65f0e on common-util/log into 06745844e13ae380bf5688ee296828ffaaf5c94a on master.

at15 commented 7 years ago

LGTM

at15 commented 7 years ago

LGTM

coveralls commented 7 years ago

Coverage increased (+1.5%) to 58.989% when pulling ddab70d8e644620112a28c927fed80543c453e81 on common-util/log into 06745844e13ae380bf5688ee296828ffaaf5c94a on master.