Add pullapprove and detail for contribution

dyweb / blog

Dongyue Tech Blog

https://blog.dongyueweb.com

14 stars 7 forks source link

Closed at15 closed 7 years ago

at15 commented 7 years ago

@gaocegege @arrowrowe

Update

[x] fix typo depoly in CONTRIBUTING.md mentioned by @JasonQSY
[x] reduce blog reviewer to 2
[x] show hint for creating author page when author is not presented
[x] show yaml to let user copy and paste into config.yaml, or use some dark magic to do string replace instead of dump yaml, latter would erase all the comment
[x] create a team for blog and add to this project's collabrator so more people like @JasonQSY can review

arrowrowe commented 7 years ago

Think the last one most important...

gaocegege commented 7 years ago

yeah, if someone want to post an article to this blog, just create a new markdown file and run the scripts named "pre-deploy.sh" and commit.

maybe he or she have to add a new author in config.yml If he or she have never posted an article before.

easy, right?

gaocegege commented 7 years ago

为什么我们三个菜鸡都要用英语呢

JasonQSY commented 7 years ago

Move the workflow to contribution.md ?

at15 commented 7 years ago

@JasonQSY yeah, also need to have the template in .github folder, btw: why are u still playing game at this time ....

at15 commented 7 years ago

some notes for setting up the project. will be merged into readme

JasonQSY commented 7 years ago

@at15 It seems that some problems happened and the game does not quit normally...

gaocegege commented 7 years ago

re @at15 There is no need to have a go environment, we could just download the binary from http://www.chole.io/

at15 commented 7 years ago

@gaocegege when I execute create-post.sh I get the error scripts/create-post.sh: 8: set: Illegal option -o pipefail

maybe we should switch to py to avoid all those issues from shell script?

gaocegege commented 7 years ago

re @at15 No need, just remove those statements :)

at15 commented 7 years ago

cc @arrowrowe @gaocegege I have updated the issue, do you mind handle the last item (create new github team) while I handle the rest, thx.

arrowrowe commented 7 years ago

@at15 I've created @dyweb/blog and add it as this repo's admin. Leave pullapprove things to you. thx.