dyweb / blog

Dongyue Tech Blog
https://blog.dongyueweb.com
14 stars 7 forks source link

posts: Add GSoC #18

Closed gaocegege closed 7 years ago

gaocegege commented 7 years ago

Signed-off-by: Ce Gao ce.gao@outlook.com

Related issue #0

Post info

gaocegege commented 7 years ago

CI fails because of the wrong version of golang. It was fixed in #17

at15 commented 7 years ago

@gaocegege mind update the PR description? the example content should not be there 😄

gaocegege commented 7 years ago

Done

at15 commented 7 years ago

LGTM

LGTM

Approved with PullApprove

at15 commented 7 years ago

cc @arrowrowe @ComMouse need another LGTM from any of you

arrowrowe commented 7 years ago

我没啥意见, 上面的错别字改下就好了...

LGTM:sheep:

Approved with PullApprove

at15 commented 7 years ago

@gaocegege it seems you need to merge it manually due to CI failing ....

gaocegege commented 7 years ago

OK

gaocegege commented 7 years ago

remote: error: GH006: Protected branch update failed for refs/heads/master. remote: error: Required status check "code-review/pullapprove" is expected. To github.com:dyweb/blog.git ! [remote rejected] master -> master (protected branch hook declined) error: failed to push some refs to 'git@github.com:dyweb/blog.git'

gaocegege commented 7 years ago

=。= 原来改标题就好了

gaocegege commented 7 years ago

修改了 typo,要重新 review。。

at15 commented 7 years ago

LGTM /w\

Approved with PullApprove

ComMouse commented 7 years ago

LGTM

Approved with PullApprove

at15 commented 7 years ago

LGMT

at15 commented 7 years ago

LGTM

Approved with PullApprove

at15 commented 7 years ago

oops, forgot to build the html .... @gaocegege