search

dyweb / dy-bot

Our handsome and cute bot
Apache License 2.0
5 stars 2 forks source link

code base: Init #1

Closed gaocegege closed 6 years ago

gaocegege commented 6 years ago

/cc @at15

gaocegege commented 6 years ago

Actually I prefer the test-infra in Kubernetes but it is a little heavy.

at15 commented 6 years ago

... @gaocegege why commit entire vendor when you have Gopkg.lock

at15 commented 6 years ago

And for directory layout, I prefer only put main in the cmd package and put most logic in pkg, though it's just personal flavor

cmd
   - dybot
      main.go
pkg
   - server
   - util
     - logutil
gaocegege commented 6 years ago

it is a little 重复。

at15 commented 6 years ago

@gaocegege 没有 util 后缀很容易跟其他变量名冲突，而且一般使用的时候包名带 util 也能跟很多标准库的包名避免冲突

gaocegege commented 6 years ago

We do not use any 标准库, we love gcommon

at15 commented 6 years ago

@gaocegege 以及我们把 dyweb 的 team 整理一下吧 ... 很多人都是不 active 的了, 就不要轰炸他们的邮箱了

gaocegege commented 6 years ago

你来吧，很多我都不认识。。