search

dyweb / dy-bot

Our handsome and cute bot
Apache License 2.0
5 stars 2 forks source link

[dep] Remove vendor folder #3

Closed at15 closed 6 years ago

at15 commented 6 years ago

Since we are already using dep, I prefer not committing vendor into repo. Just add dep ensure to Makefile and let developer call it.

at15 commented 6 years ago

@gaocegege I am fixing usage of gommon/log now, I can do this in the same PR

gaocegege commented 6 years ago

好吧。。但这个会使得 CI/CD 很慢。。

gaocegege commented 6 years ago

/assign @at15

at15 commented 6 years ago

@gaocegege CI/CD 变慢我倒是没想过(可能已经习惯等 travis 的时候看 b 站了 ...

gaocegege commented 6 years ago

我建议你直接在 master 上操作，reset 掉有 vendor 的提交，不然 repo 还是会很大

at15 commented 6 years ago

@gaocegege reset 可能还是会有记录吧? 我得强改历史记录 push -f 了感觉 ... https://stackoverflow.com/questions/10067848/remove-folder-and-its-contents-from-git-githubs-history

gaocegege commented 6 years ago

那肯定得 push -f

at15 commented 6 years ago

updated using 

git filter-branch --tree-filter 'rm -rf vendor' --prune-empty HEAD

the so answer has git for-each-ref --format="%(refname)" refs/original/ | xargs -n 1 git update-ref -d I didn't use it but things seems to be working now ...

at15 commented 6 years ago

Travis finished in 2 minutes https://travis-ci.org/dyweb/dy-bot/jobs/376691278