search

dyweb / weekly

DevComm-Shanghai Weekly 上海地区高校技术社团联合周报（欢迎投稿）
https://dyweb-weekly.netlify.com/
65 stars 5 forks source link

Fix for Dockerfile smell DL3003 #352

Closed grosa1 closed 1 year ago

grosa1 commented 1 year ago

Hi! The Dockerfile placed at "Dockerfile" contains the best practice violation DL3003 detected by the hadolint tool.

The smell DL3003 occurs if the pattern RUN cd ... is used to change directories instead of the dedicated WORKDIR instruction. This pull request proposes a fix for that smell generated by my fixing tool. The patch was manually verified before opening the pull request. To fix this smell, specifically, the pattern RUN cd ... is replaced with the equivalent WORKDIR instruction.

This change is only aimed at fixing that specific smell. If the fix is not valid or useful, please briefly indicate the reason and suggestions for possible improvements.

Thanks in advance

ComMouse commented 1 year ago

Thank you and the change looks good to me! This Docker job is not really actively maintained anymore but we still appreciate your efforts. I'll merge it soon.