dywisor / tlp-portage

portage overlay for TLP
https://github.com/dywisor/tlp-gentoo-additions
57 stars 10 forks source link

Linux-x86-power-tools not building on musl #16

Open aux-j opened 6 years ago

aux-j commented 6 years ago

Hi there,

Linux-x86-power-tools was not building on musl due to a missing include in turbostat.c - Here's a patch I've just whipped up to get it working:

diff --git a/tools/power/x86/turbostat/turbostat.c b/tools/power/x86/turbostat/turbostat.c index 5b1b807..055a514 100644 --- a/tools/power/x86/turbostat/turbostat.c +++ b/tools/power/x86/turbostat/turbostat.c @@ -30,6 +30,7 @@

include <sys/stat.h>

include <sys/resource.h>

include

+#include

include

include <sys/time.h>

include

leezu commented 6 years ago

You should propose this patch upstream in the linux kernel https://github.com/torvalds/linux/blob/master/tools/power/x86/turbostat/turbostat.c

dywisor commented 5 years ago

Sorry for catching this one late.

As @leezu suggested, please propose this patch upstream as it could also affect other packages relying on the same code base such as sys-apps/linux-misc-apps.

aux-j commented 5 years ago

Hi @dywisor,

Sorry for the late reply, I'll submit a PR. Thanks!

dywisor commented 5 years ago

@gitlab-j Can you provide me with a link to the corresponding bug report for tracking purposes?

I'll include a patch in the next sys-power/linux-x86-power-tools ebuild, but eventually I'd like to see this fixed upstream.