search

dyz1990 / sevenz-rust

A 7z decompressor/compressor lib written in pure rust
Apache License 2.0
146 stars 24 forks source link

Run rustfmt and clippy on the CI #38

Closed sorairolake closed 9 months ago

sorairolake commented 9 months ago

I suggest to add something like the following to rust.yml:

    - name: Check rustfmt
      run: cargo fmt -- --check
    - name: Check clippy
      run: cargo clippy -- -D warnings
    - run: cargo clippy --all-features -- -D warnings
    - run: cargo clippy --no-default-features -- -D warnings

I think this helps maintain the code quality.

dyz1990 commented 9 months ago

@sorairolake Sounds good, can you submit a PR?

sorairolake commented 9 months ago

@dyz1990 No, this will require fix the clippy warnings, so I think it would be better for the author (you) to do this.