dzaima / CBQN

a BQN implementation in C
GNU General Public License v3.0
329 stars 46 forks source link

Some changes for Windows builds with llvm-mingw #66

Closed actalley closed 1 year ago

actalley commented 1 year ago

These changes allow a build to succeed on Windows using llvm-mingw with the below command line. No •SH, •FFI, or repl support for now, and other things may be broken. Files with Unix line endings can be run with -f.

clang.exe -std=gnu11 -Wall -Wno-unused-function -fms-extensions -ffp-contract=off -fno-math-errno -Wno-microsoft-anon-tag -Wno-bitwise-instead-of-logical -Wno-unknown-warning-option -DBYTECODE_DIR=bytecodeSubmodule -DSINGELI=0 -DFFI=0 -fvisibility=hidden -DCBQN_EXPORT -DNO_MMAP -O3 -o bqn.exe src/opt/single.c -lm -lpthread
dzaima commented 1 year ago

could you cherry-pick the commit onto master to avoid the merge (for no particular reason other than me not liking a double-merge)? or should I do it along with the changes I'll make (also did matrix just die ¯\_(ツ)_/¯ (edit: yes))

actalley commented 1 year ago

Something is definitely going on with matrix. My messages have not been going through for a while. I didn't see both commits. Sorry about that. I'll try the cherry-pick

dzaima commented 1 year ago

(fwiw, instead of making a new PR, you can force-push to an existing PR's branch & it'll update)

actalley commented 1 year ago

Will that work with a cherry-pick onto master?

dzaima commented 1 year ago

it should work with anything afaik

actalley commented 1 year ago

After the cherry-pick I'm not seeing how to update the PR

dzaima commented 1 year ago

you pushed to your master branch, not windows.

actalley commented 1 year ago

Then I misunderstood what needed to be done. I don't know how to fix this

dzaima commented 1 year ago

pushed directly to develop as you did make a correct commit

dzaima commented 1 year ago

pushed some trivial changes to develop

actalley commented 1 year ago

I think I see what I did wrong. The next one will be cleaner