search

dzcode-io / dzcode.io

Website & mobile app for Algerian open-source community
https://dzcode.io
MIT License
114 stars 41 forks source link

Fix the functionality of the search button on dzcode #156

Closed AhmedAbdelhak1 closed 3 years ago

AhmedAbdelhak1 commented 4 years ago

Describe the bug when pushing the search button nothing happen.

To Reproduce Steps to reproduce the behavior:

  1. Go to 'https://www.dzcode.io/'
  2. Click on 'Search button on the left side on the top of the website'

Expected behavior It should be a text area for writing when pushing the search button.

Desktop (please complete the following information):

Additional context Browser: Google Chrome.

ZibanPirate commented 3 years ago

Thanks for reporting the bug @AhmedAbdelhak1 will investigate ASAP

AM-77 commented 3 years ago

The problem is: there is no event handling nor the input field. the whole search functionality does not exist at all.

https://github.com/dzcode-io/dzcode.io/blob/f56f2fda7c0ad5c0eec370ca8383ac6939a1498b/frontend/src/apps/main/components/navbar/index.tsx#L135

ZibanPirate commented 3 years ago

@AM-77 and @AhmedAbdelhak1 , since the content was not clear at the time we implemented the search component, we didn't have a clear decision on what to search for, but now it's clear that we search for the three main sections of the website (documentation, projects, article), will postpone this feature for the next milestone

NurElHuda commented 3 years ago

This one will be handled in #216