Closed ZibanPirate closed 2 years ago
i can take up the 3rd task, the one about implementing Redux
@ZibanPirate Okay sounds cool to me, as you can see in the redux
folder, there is the structure for it, from actions creators to action types to reducers, each reducer should do specific tasks, I am guessing that we should separate reducers for each screen, as for this one maybe it will be ContributeReducer
, so what do you think?
I can do the other tasks
generally, we will have two types of reducers, Screen Reducer for eg: contributeScreen
reducer, and Data reducer for eg: settings
reducer, the first one contains state of the Contribute screen: contributions, filters ..etc, similar to the web one, and the settings reducer will also be similar to the web's setting reducer which for now contains darkMode
Good idea, we'll work on that way then
@ZibanPirate would you see the #355 PR to see WIP code, so maybe you can continue what left. PS: for the empty state it would be awesome if we have some pngs or maybe lottie files that shows the dzcode.io logo in it.
still only the last task for this issue, then we can close it 👌
still only the last task for this issue, then we can close it 👌
@ZibanPirate I'm going to work on it
closing as done in #364
Description
Follow up PR on #342
Check List
Additional Comments
The tasks are from this comment, please feel free to add more if anything is missing.