search

dzcode-io / dzcode.io

Website & mobile app for Algerian open-source community
https://dzcode.io
MIT License
114 stars 42 forks source link

using cypress for e2e tests in `./web` #561

Closed omdxp closed 1 year ago

omdxp commented 1 year ago

Description

Type of change

omdxp commented 1 year ago

Also @ZibanPirate I was thinking to add a branch protection rule to force squash before merge right from here as there are many commits that aren't needed to be in the main history

ZibanPirate commented 1 year ago

Also @ZibanPirate I was thinking to add a branch protection rule to force squash before merge right from here as there are many commits that aren't needed to be in the main history

let's keep the current configuration (merge commit) for transparency, squash commit has some downsides, such as you can't have cascading PRs.

btw unit tests are failing, let's modify https://github.com/dzcode-io/dzcode.io/blob/e9ac068129601db50695af071da47b2b72fe32ac/packages/tooling/jest.config.ts#L8-L9

to be:

  coveragePathIgnorePatterns: ["<rootDir>/src/_test", "<rootDir>/src/e2e_test"],
  testPathIgnorePatterns: ["<rootDir>/(?!src)", "<rootDir>/src/_test", "<rootDir>/src/e2e_test"],