dzcode-io / leblad

A JS library providing a list of Algerian administrative areas with many useful APIs.
https://www.npmjs.com/package/@dzcode-io/leblad
MIT License
63 stars 20 forks source link

Feature request: Extend wilayaProjection to project nested fields #28

Closed InternetRamen closed 3 years ago

InternetRamen commented 4 years ago

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Extended wilayaProjection to project nested fields.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

Checklist:

My friend @makeBread helped me with this.

InternetRamen commented 4 years ago

I don't know how to fix 6 eslint errors.

InternetRamen commented 4 years ago

@Fcmam5 I'm not sure I would be able to call as my coding times are unpredictable based on my school work. Are there any main improvements that could be added to the code?

Fcmam5 commented 4 years ago

This code is too complex, and that's why ESLINT reported a Cognitive Complexity error. I'm looking for a library (or probably create one) that makes it easier to do this. I will get back to you as soon as I find something.

InternetRamen commented 4 years ago

@Fcmam5 Alright, thank you!