Feature request: getWilayaByDairaName

dzcode-io / leblad

A JS library providing a list of Algerian administrative areas with many useful APIs.

https://www.npmjs.com/package/@dzcode-io/leblad

MIT License

63 stars 20 forks source link

Feature request: getWilayaByDairaName #43

Closed Fcmam5 closed 4 years ago

Fcmam5 commented 4 years ago

Implement a new feature: getWilayaByDairaName. That takes a Daira name (French, English or Arabic) and returns either the corresponding wilaya or null.

getWilayaByDairaName(name: string, projection?: string[]): WilayaObject

Please, don't forget to update the documentation in the README file (check this example PR).

joeylnguyen commented 4 years ago

Hi, can you assign this to me?

Fcmam5 commented 4 years ago

Sure, Happy hacking!

joeylnguyen commented 4 years ago

@Fcmam5, was this feature not already implemented in #20?

Fcmam5 commented 4 years ago

@joeylnguyen it was 😞 sorry I missed that, but it was not exported from index.js and we missed that, please can you submit a PR to fix this?