Open ibrahimgb opened 2 years ago
hey @ibrahimgb thanks for the PR, is there a need or a reason for this change?
Merging #74 (cf2c0e6) into develop (3fe8e06) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## develop #74 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 20 20
Lines 173 173
Branches 33 33
=========================================
Hits 173 173
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 3fe8e06...cf2c0e6. Read the comment docs.
reason for this change: the hole data was crammed in one line. I just organize it to make it easy for future contributions (who want to update the dataset).
hey @ibrahimgb thanks for the PR, is there a need or a reason for this change?
Hi @ibrahimgb the idea was to pull the dataset from the files in https://github.com/Fcmam5/algeria-api which is now super outdated. And the data in one-line here is meant to use a compressed version of the dataset for a tiny-ish performance gain.
Or, do you have any suggestions for doing this better? We can keep the prettified version of the dataset and only minified when building the library
Description
i have reorganized the code layout for the data file I have not edited nor changed the data
Fixes # (issue)
Type of change
reorganized
Please delete options that are not relevant.
Checklist:
npm run update-dataset
)npm test
passes on my machinenpm run lint
passes on my machine