Open gcox opened 7 years ago
I'd love to see this project spun off into a new organization—maybe just called DZNEmptyDataSet
? The major contributors to the project, basically whomever @dzenbot nominates, could be given commit rights, and the project could just sort of evolve. Meanwhile, perhaps this particular version could be frozen and all issues and PRs ported over by the new maintainer community for them to do with as they please. That way, there wouldn't be a major shock to anyone using this repo, nor would @dzenbot have to do any further work beyond creating a new org, choosing a half-dozen people arbitrarily, and saying 'have at.'
It's not an apples-to-apples comparison, but this seems similar to the transition that Jesse Squires helped facilitate for https://github.com/jessesquires/JSQMessagesViewController, which can now be found at https://github.com/MessageKit/MessageKit/
+1
+1
I think this library should be rewritten in Swift... There are some alternatives like:
https://github.com/HamzaGhazouani/HGPlaceholders https://github.com/teambition/TBEmptyDataSet and this one which looks like it is the implementation of this library in Swift
A swift rewrite would be great as long as it still works with objc projects. Many of the alternatives don’t play nicely with table and collection view controllers written in objc.
Sent from my iPhone
On Jan 18, 2018, at 10:51 AM, Ran Hassid notifications@github.com wrote:
I think this library should be rewritten in Swift... There are some alternatives like:
https://github.com/HamzaGhazouani/HGPlaceholders https://github.com/teambition/TBEmptyDataSet and this one which looks like it is the implementation of this library in Swift
https://github.com/Xiaoye220/EmptyDataSet-Swift
— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.
I think this library should be rewritten in Swift...
What are the problems that you'd be addressing by rewriting this library in a new language?
@aaronbrethorst I don't see any problems so far but if this library is not maintained anymore and you are anyway planning to take ownership on it then I think you should consider to rewrite it in Swift since it's not big. Anyway, I've noticed that it's already written in Swift in here: https://github.com/Xiaoye220/EmptyDataSet-Swift so it's not relevant...
I agree with @aaronbrethorst, if there's no major benefit to a Swift rewrite, doing so could introduce bugs and regressions. It's already usable in Swift codebases, so the benefits would be minimal at best.
@aaronbrethorst I like the idea of moving this project to its own organization, and hopefully get a handful of active contributors. On the other hand, I reviewed https://github.com/Xiaoye220/EmptyDataSet-Swift and it seems like a pretty good translation of the objc source code, with total feature parity. Nice work @Xiaoye220! 👏
Maybe, we can have both projects, side by side, assuming the author of EmptyDataSet-Swift would be on board. The only problem with a fully swifty version, is not being compatible with Objc. Many users still have to maintain old code bases (self included). Maintaining both projects might also be an overhead, considering I haven't being doing a good job at it already with 1 project 😓
@dzenbot that sounds like a great idea!
@dzenbot Thank you! 😁😁😁
Hi @dzenbot and @aaronbrethorst after some more search I found https://github.com/teambition/TBEmptyDataSet I think you should also check this one. Both libraries very similar to each other so maybe we can also "merge" them because the TBEmptyDataSet supports margin for the title and description which I think is very helpful in order to avoid custom views. I think that both libraries were inspired by this library and are very good alternative for pure Swift projects.
Is there a recommended fork that is actually maintained?