search

dzenbot / DZNPhotoPickerController

A photo search/picker for iOS using popular image providers like 500px, Flickr, Instagram, Giphy, Google & Bing Images
https://www.cocoacontrols.com/controls/dznphotopickercontroller
MIT License
1.51k stars 266 forks source link

Fixed samples and updated to CocoaPods 1.0 format #130

Closed ahbou closed 8 years ago

ahbou commented 8 years ago

Cleared Pods cache that prevents building from the repo Added gitignore to prevent Pod files from being checked it to Git Updated Pod files to 1.0 format

dzenbot commented 8 years ago

This PR has way too many changes. 634 files changed?

I would rather if you could first submit a PR that updated to Cocoapods v1. Then, make a separate PR for https://api.riffsy.com support. Is it a gif service like giphy?

ahbou commented 8 years ago

Yes it's like giphy but their terms of use are less restrictive. The Pods were checked-in to git too hence the massive files number. they should be recreated locally using the podfile on pod install. I'll make a new PR with the changes for Cocoapods v1 but consider removing the Pods directory from git.

dzenbot commented 8 years ago

I generally prefer checking the pod files into the git, so whoever clones the repo, the sample project would build out of the box.

ahbou commented 8 years ago

I get it it's just that everyone has a different setup so it's most likely to fail building. podfile.lock guarantees the integrity of the versions. I made a new PR