Pod cleanup, KVO crash fix, progress bar fix

dzenbot / DZNWebViewController

A simple web browser for iPhone & iPad with similar features than Safari's

https://www.cocoacontrols.com/controls/dznwebviewcontroller

MIT License

1.06k stars 181 forks source link

Pod cleanup, KVO crash fix, progress bar fix #70

Open alexhillc opened 7 years ago

alexhillc commented 7 years ago

Cleanup Pod files by adding the Pods directory to .gitignore (a 'pod install' will be needed after cloning, but this reduces clutter in the repo generated by the Sample app)
- Retain reference to navigation bar to fix temperamental KVO crash on dealloc.
- Clear progress view in viewDidDisappear:, dealloc as well as viewWillDisappear: - just in case there is a situation in which we receive delegate progress callbacks.
- Add parens to statement causing warning in Xcode 8.3

sgonzalesallan commented 7 years ago

I think this pull request will address the issue in progress bar bug when pushing the web view controller, as well as the bug in the activity indicator when the controller is dismissed while loading. Good job @alexhillc 👍