search

dzhavat / css-flexbox-cheatsheet

VS Code extension that lets you open a CSS Flexbox cheatsheet directly in the editor.
https://marketplace.visualstudio.com/items?itemName=dzhavat.css-flexbox-cheatsheet
MIT License
101 stars 12 forks source link

Extension disables "⌘ + K" to clear the terminal on terminal focus #40

Open fredThem opened 2 years ago

fredThem commented 2 years ago

Issue Type: Bug

Focus on the terminal use "⌘ + K" should be equivalent to typing "clear".

Extension version: 3.3.0 VS Code version: Code 1.62.3 (Universal) (ccbaa2d27e38e5afa3e5c21c1c7bef4657064247, 2021-11-17T07:59:13.865Z) OS version: Darwin x64 20.6.0 Restricted Mode: No

System Info |Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz (16 x 2300)| |GPU Status|2d_canvas: enabled
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
oop_rasterization: enabled
opengl: enabled_on
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
webgl: enabled
webgl2: enabled| |Load (avg)|4, 3, 2| |Memory (System)|64.00GB (34.40GB free)| |Process Argv|--crash-reporter-id 6a8a0bb9-5ded-496d-9a7c-a7f8e118b407| |Screen Reader|no| |VM|0%|
A/B Experiments ``` vsliv368cf:30146710 vsreu685:30147344 python383cf:30185419 vspor879:30202332 vspor708:30202333 vspor363:30204092 pythontb:30283811 pythonptprofiler:30281270 vshan820:30294714 vstes263:30335439 vscorecescf:30384386 pythondataviewer:30285071 vscod805cf:30301675 pythonvspyt200:30340761 binariesv615:30325510 bridge0708:30335490 dockerwalkthru:30377721 bridge0723:30353136 pythonrunftest32:30373476 pythonf5test824:30373475 javagetstartedt:30391933 pythonvspyt187:30373474 vsqsis200cf:30402084 vsaa593cf:30376535 vssld246cf:30401891 vscop804:30404766 vscop341:30404997 ```
dzhavat commented 2 years ago

Hey @fredThem thank you for reporting this bug.

I just tried investigating it and have a suspicion that the keyboard shortcut you use to clear the Terminal might be custom. It looks like VS Code doesn't assign any keyboard shortcut for clearing the Terminal by default.

Here's a screenshot of my keyboard shortcuts. (Note: I'm using Windows)

image

May I ask you to check yours? Could it be that the "⌘ + K" is something you've set yourself?

fredThem commented 2 years ago

Hi @dzhavat , it's the default setting on VSC for Mac. I had to do an extension bisect that pointed out to your extension. CleanShot 2021-12-15 at 16 46 03 CleanShot 2021-12-15 at 16 48 00

dzhavat commented 2 years ago

@fredThem Thanks for getting back with more info. I can see that VS Code has different set of keyboard shortcuts on Mac. Sorry for conflicting with them with my extension.

As a quick fix, assuming you still want to use the extension, you can remove the binding by searching for the "flexbox.cheatsheet" command, then right clicking on the row and selecting "Remove Binding". You'll still be able to open the extension by using the command palette or clicking on any display: flex CSS declaration.

Another option is to assign a different key binding of your choice to the extension but this might interfere with another keybinding for something else.

In the mean time I will try to find a way to keep the key binding for the extension but activate it only if the Terminal is not in focus.