search

dzhvansky / pepato

GNU General Public License v3.0
1 stars 2 forks source link

emg labels #10

Closed aremazeilles closed 4 years ago

aremazeilles commented 4 years ago

In your emg files, I see that you use the left and right suffix.

In the documentation, we do not mention that possibility. So I guess we should add it.

Regarding the left / right labelling, we have a similar discussion for the joint names. Right now we store them using l,r as prefix, but in the issue, a parnter is suggesting a suffix use. But still using only l or r, not left or right.

Do you have an opinion on this? Is there is a tendency forstoring emg data? Could we go towards a similar way of writting it?

At minimum, I would like all emg files to follow the same policy, this is why I would like to bring this to the data format file.

dzhvansky commented 4 years ago

For EMG data, I think it is common practice to use suffixes for left and right. Therefore, I suggest to leave this format. As for full names, it is OK, I will use l and r as suffixes to match Eurobench data format.

dzhvansky commented 4 years ago

Updated, now both full _left and short _l body side suffix are available. Test files column names are changed to the short version (i.e. BiFe_l).

aremazeilles commented 4 years ago

Sounds good to me as is right now, thanks