Create domain object "concept"

[rreitmann]

As Public User I want to search for concepts

The Domain Object "Concept" should be created as author specific (e.g. Big5 Short Scale by B. Rammstedt).

There should be relations to study and question level (related by Concept ID).

There should be an interface to edit the attributes of a "Concept".

The attributes of the DO "Concept" should be derived from the paper written by @annegaertner .

[AndyDaniel1]

Broad Definition Concepts represent theoretical (latent) contructs which are measured in an instrument by questions and items.

Relations Due to the fact that the same concept could be used in different studies, the relation between a concept and studies is 1-n .

Out of pure theory, the relation between concepts and questions is 1-1 because the same concept should always be measured in the same manner. Problem: In fact exist different ways to measure concepts and due to this the concept question relation is (in fact) 1-n.

Further we should discuss if concepts have study/survey specific attributes like reliability and validity in survey xy (which contradicts the concept studies relation of 1-n).

Attributes General attributes of the domain object concept are (to be done):

-

[rreitmann]

Here is the picture of what we talked about today:

Missing things:

• icon for domain object concept
• german translation for concept
• attachment types (do we need types)

[annegaertner]

I suggest the following attachment types:

• documentation (this is the document that describes the whole development of a concept)
• answer sheet (this displays the actual part of the instrument that surveys the concept, e. g. a certain question including question text and all possible answers) -> I am not sure whether this information repeats as soon as the their is information on "questions". Since not all studies contain "questions", I thought this attachment might be useful.
• other

[rreitmann]

In order to clarify the definition of a concept: Big5 itself is not a concept, it is a (or the) model for conceptualizing "Personality".

[rreitmann]

We need to implement the following things:

• [ ] Create/Edit concept
  • [x] Page title and toolbar header are set correctly
  • [x] Only Publisher can edit/create concepts
  • [ ] Validations (see asterisks in picture above)
  • [x] Historization of concepts
  • [x] id must not exist validator (on creation, async, angular)
  • [x] All details can be edited
    • [x] tag editor for concepts (different validation then study.tags)
    • [x] md-chips based chooser for original languages
    • [x] input for doi (validate syntax?), license string
  • [x] Create/Edit concept attachments
    • [x] Validations
    • [x] Historization of concept attachment metadata
• [x] Delete concept
  • [x] Only Publisher can delete concept
  • [x] Concepts which are used by questions or instruments cannot be deleted (error message indicating by which questions or instruments the concept is used)
• [x] Concept search
  • [x] Filter by study, survey, instrument, question, data set, variable as authenticated user
  • [x] Filter by study, survey, instrument, question, data set, variable as public user
  • [x] Search by content of concept
• [ ] Concept Details View
  • [ ] All users can see concepts and can follow the links to either the linked masters (if logged in) or the current version of the linked domain object
  • [x] Page title and toolbar header are set correctly
  • [x] Links to one study, survey, instrument, question, data set, variable (master or latest shadow)
  • [ ] Links to many study, survey, instrument, question, data set, variable (masters or latest shadows, different counts when authenticated/not authenticated)
  • [x] All concept details are displayed
  • [x] All attachments are displayed and downloadable
  • [x] Browse search results by next, previous handler
• [x] Study Details, Survey Details, Instrument Details, Question Details, Data Set Details, Variable Details
  • [x] Link to one concept
  • [x] Link to many concepts
• [x] instrument edit
  • [x] data provider and publisher can assign concepts
  • [x] md-chips based field for assigning multiple concepts (can be empty)
  • [x] concept must exist validator (backend)
• [x] question upload
  • [x] data provider and publisher can assign concepts
  • [x] upload question with multiple conceptIds
  • [x] concept must exist validator (backend)

[rreitmann]

@rbirkelbach Latest icon version has been integrated, however line weight is IMHO to high

[rbirkelbach]

Could you make a screenshot with the other icons next to it? As far as I can see it's not already deployed to the dev system

[rreitmann]

[rbirkelbach]

It looks as if the lines are a tiny bit thicker than the lines of the other icons (although I don't know how to verify this). I think it would be good to have the oval a bit wider and then use a tiny bit wider rectangles in combination with a bit thinner lines. Do you agree?

[rreitmann]

yep

[rbirkelbach]

I sent her an email with some suggestions.

[rreitmann]

Here are some review remarks:

• [x] when I try to delete a concept in use I must get an alert toast which does not disappear without clicking on it
• [x] when I try to delete a concept in use which is used by instruments and questions, I can only see an error message for questions
• [x] original languages should be just a comma separated list on the details card of the details page
• [x] languages on edit page are always displayed in german no matter if I choose english or german before entering the page
• [x] as public user links from concept details to other (single) objects do not work (study not found, question click does not do anything)
• [x] all components (directives, resources) related to country codes and languages should be moved to common/i18n

[rreitmann]

• [x] countryCodes.resource.js is still under surveymanagement
• [x] filtering concepts by instruments shows "4 concepts found" although there are just 2 (nestedInstruments, instruments in concept are not deduplicated as well)
• [x] choosing languages only by keyboard (with enter) does display an empty chip
• [x] we need an instrument changes provider and a question changes provider because removing a concept from an instrument/question is not captured by the concept service

[rbirkelbach]

• [ ] english label is missing for concept-management.edit.label.id (only firefox)
• [ ] con-text$ is unintuitive. Better to add con- and $ automatically after the user entered the text
• [x] sometimes the async validator shows a 404 not found toast
• [ ] In the details I'd put the DOI last, because the user will probably decide to click on it only after they read the other details and evaluated whether it's interesting for them or not.
• [ ] {{question-management.error.question.concept-ids.not-exists}} has no label

[rbirkelbach]

In the details I'd put the DOI last, because the user will probably decide to click on it only after they read the other details and evaluated whether it's interesting for them or not.

[rbirkelbach]

• {{question-management.error.question.concept-ids.not-exists}} has no label

[rbirkelbach]

Link from question to concept works, but no link shown the other way around (from concept to question) eventual consistency...

[rreitmann]

@rbirkelbach you can retest when PR #2264 has been merged...

[rreitmann]

We still need to document concepts here: https://github.com/dzhw/metadatamanagement/wiki/Domain-Model

[rbirkelbach]

I couldn't reproduce the bugs.

[UteH]

@rbirkelbach @rreitmann Is there a user documentation of concept yet? I could not find it in readthedocs

[rreitmann]

Nope

[annegaertner]

@UteH I already started a documentation, which should be transferred to readthedocs after finalization, but is here for now: \\faust\Abt4\FDZ\2_Standards\Skalendokumentation (Modul A3)\Vorarbeiten\MDM_Konzepte_Prozess_Anleitung.docx