search

dzid26 / StepperServoCAN

Closed loop stepper motor controller with CANbus capabilities. This Project open source hardware and code, support platformio build and upload firmware.
https://shop.retropilot.org/product/stepperservocan
19 stars 5 forks source link

StepperServoCAN hardware does not have display #10

Closed killinen closed 1 year ago

killinen commented 1 year ago

Hi, I haven't done this pull request stuff before so this is more practice than real "development". I think there was some misinformation in the README regarding of using display to change the rotation of the motor (most likely legacy stuff). Don't know why the code show also changes in line 101.

Ps. sorry for not "replying" to your pull requests, have to start look into those :)

dzid26 commented 1 year ago

Yes, it was legacy. The reason I haven't fully removed the display stuff was that I thought maybe it would be useful to have a virtual display via debugger semihosting to the PC's console. In practice, it would be better to have a setting of the actuator configuration via CANbus.