search

dzid26 / StepperServoCAN

Closed loop stepper motor controller with CANbus capabilities. This Project open source hardware and code, support platformio build and upload firmware.
https://shop.retropilot.org/product/stepperservocan
19 stars 5 forks source link

CAN data overflow (speed signal) #8

Open dzid26 opened 1 year ago

dzid26 commented 1 year ago

None of the conversions from float to int is protected. https://github.com/dzid26/StepperServoCAN/blob/85e330b707d7960a3cb05b9c8397ab239e6193ab/firmware/src/OP/Msg.c#L239-L242 This ideally should be done by fixing cantools.

image

This happens at high speed with no load.

dzid26 commented 1 year ago

Let's either hack it (limit the speed to something below limit from DBC) or modify cantools submodule.