dziemborowicz / hourglass

The simple countdown timer for Windows.
MIT License
650 stars 114 forks source link

Add support for the zh-CN locale #125

Open Riajyuu opened 8 years ago

Riajyuu commented 8 years ago

I would like to help with Zh-CN locale. If necessary, give me a email.

dziemborowicz commented 8 years ago

I'm certainly happy for more locales to be added. Most of the app is localizable, so it's just a matter of translating those strings, I would think. There is a problem in that the logic for parsing the input strings, where you type, for example, "5 minutes 30 seconds" is quite complicated (and the code is a mess). That code would be difficult to localize properly (though perhaps localizing a subset is a possibility?).

Riajyuu commented 8 years ago

I believe it won't be an issue. Simply change corresponding code as the locales change. As you say,

localizing a subset is a possibility

In this case, logic relation in Chinese is same as that in English.