search

dzikirqu / dzikirqu-android

Is an All in One app for Muslims with lots of features such as Prayer Times & Adhan, Collections of Dhikr and Prayer sourced from Authentic Hadith, The Holy Qur'an, Qibla, Notes and many more!
GNU General Public License v3.0
128 stars 33 forks source link

Support full height share #19

Closed andraantariksa closed 2 years ago

andraantariksa commented 2 years ago

What kind of change does this PR introduce?

To support full height heigh share when the content overflows the view size

What is the current behavior?

The current behavior is done by clipping the text

image

What is the new behavior?

The full height share is achieved by wrapping the content with NestedScrollView so the full height view can be captured

image

I removed the play store image here

Others

Additionally, I think its best to just remove the Download from Google Play since it would be annoying. Showing a logo is fine, but showing Download from Google Play looks weird.

andraantariksa commented 1 year ago

Hey @wagyufari , what about my question? It is still an idea, I haven't done anything

Additionally, I think its best to just remove the Download from Google Play since it would be annoying. Showing a logo is fine, but showing Download from Google Play looks weird.