fix #104: Show connection string from where query was executed in the table tab

dzmipt commented 2 years ago

Meanwhile it is ok. However for the future, I'd like to have more details - timing and query (in addition to the server). Tooltip will not be good for this. Details should be inside output tab.

dzmipt commented 2 years ago

Overall it is good. Thank you ! I found few details:

you passed server to TabbedPane while QueryResult already has it (it is unnecessary).
I don't like that anonymous servers result in a tip like (server:host).

What I am going to do is to accept the PR and fix the above myself. TBH, I am learning how to review PR here. I decided that for us the key is to make the feature implemented in the repo rather to ping/pong with comments until PR is perfect. However if you think otherwise, pls let me know.

Yanpas commented 2 years ago

No problem, all the comments sound reasonable.

dzmipt / kdbStudio

fix #104: Show connection string from where query was executed in the table tab #105