dzonatan / ngx-linky

Linky pipe for angular
MIT License
41 stars 13 forks source link

Increase angular version support #23

Closed cosme-benito closed 3 years ago

cosme-benito commented 3 years ago

The peer dependencies of this library only go up to version 8 angular library.

Package.json

peerDependencies": {
    "@angular/common": "^4.0.0 || ^5.0.0 || ^6.0.0 || ^7.0.0 || ^8.0.0",
    "@angular/core": "^4.0.0 || ^5.0.0 || ^6.0.0 || ^7.0.0 || ^8.0.0",
    "autolinker": "^3.0.0"
  }

Every time I use ng-update I get an error and have to use the --force flag, which is displeasing. I see no reason not to bump the angular version

Fetching dependency metadata from registry...
                  Package "ngx-linky" has an incompatible peer dependency to "@angular/common" (requires "^4.0.0 || ^5.0.0 || ^6.0.0 || ^7.0.0 || ^8.0.0" (extended), would install "10.2.1").
                  Package "ngx-linky" has an incompatible peer dependency to "@angular/core" (requires "^4.0.0 || ^5.0.0 || ^6.0.0 || ^7.0.0 || ^8.0.0" (extended), would install "10.2.1").
× Migration failed: Incompatible peer dependencies found.
Peer dependency warnings when installing dependencies means that those dependencies might not work correctly together.
You can use the '--force' option to ignore incompatible peer dependencies and instead address these warnings later.
dzonatan commented 3 years ago

Fixed with v3.0.0