search

dzonatan / ngx-linky

Linky pipe for angular
MIT License
41 stars 13 forks source link

No compatible version for Angular 9 #35

Open akaustav opened 3 years ago

akaustav commented 3 years ago

Issue Summary

We are unable to update our private Angular 9.1.3 repository to Angular version 10 or higher at the moment until a few more months. Meanwhile, there does not seem to be a compatible version of ngx-linky with Angular version 9. Please publish a version of ngx-linky which is compatible with Angular 9.

ngx-linky@2.2.0 was compatible with Angular versions 4 thru 8. ngx-linky@3.0.0 seems to be compatible with Angular 10 and higher. As a result, the yarn install or yarn add commands keeps throwing the following warnings in our project running Angular 9:

With ngx-linky version 2.2.0

Command: yarn add ngx-linky@^2.2.0

Warnings:

warning " > ngx-linky@2.2.0" has incorrect peer dependency "@angular/common@^4.0.0 || ^5.0.0 || ^6.0.0 || ^7.0.0 || ^8.0.0".
warning " > ngx-linky@2.2.0" has incorrect peer dependency "@angular/core@^4.0.0 || ^5.0.0 || ^6.0.0 || ^7.0.0 || ^8.0.0".

With ngx-linky version 3.0.0

Command: yarn add ngx-linky@^3.0.0

Warnings:

warning " > ngx-linky@3.0.0" has incorrect peer dependency "@angular/common@>=10.0.0".
warning " > ngx-linky@3.0.0" has incorrect peer dependency "@angular/core@>=10.0.0".
akaustav commented 3 years ago

Looks like yarn reads the peerDependencies object from the package.json file:

From ngx-linky tag v2.2.0: https://github.com/dzonatan/ngx-linky/blob/04b46cb5d429c72143cf33ec81505c9d022796bd/projects/ngx-linky/package.json#L21-L25

From ngx-linky tag v3.0.0: https://github.com/dzonatan/ngx-linky/blob/50a69e30fe238edad57cf690fdeb46f424f67e60/projects/ngx-linky/package.json#L21-L25

akaustav commented 3 years ago

If it helps, both versions 2.2.0 and 3.0.0 of ngx-linky work for our use-cases within our repo running Angular 9.1.3.