search

dzonatan / ngx-linky

Linky pipe for angular
MIT License
41 stars 13 forks source link

docs(README.md): fixes argument documentation #4

Closed binarious closed 8 years ago

binarious commented 8 years ago

The arguments have to be passed as an array since they're accessed via args[0]: https://github.com/dzonatan/angular2-linky/blob/27506e6205b7c041bf3675cb2823b0ac29424141/linky-pipe.ts#L7

dzonatan commented 8 years ago

Heh.. It seems that angular in beta.16 (after this package was created) made this breaking change:

pipes now take a variable number of arguments, and not an array that contains all arguments.

I think it would be more logical to follow that standard instead of having pointless array markup. Therefore I will release the new version to use variables and close this request.

Thanks for the notice! 🍻