Support favorites nodes

dzsessona / QuickOpener-NetBeans

Sometimes while programming in NetBeans you want to explore a particular file that you are editing on the file system browser, or maybe launch a command in a terminal to do something with it.

52 stars 41 forks source link

Support favorites nodes #30

Closed markiewb closed 8 years ago

markiewb commented 11 years ago

Currently it is not possible to open a console for the selected root-node in the favorites window. The action is not enabled.

EXPECTED: Support datashadow Taken from my own plugin:

    private FileObject getFileObjectWithShadowSupport(DataObject dataObject) {
        if (dataObject instanceof DataShadow) {
            DataShadow dataShadow = (DataShadow) dataObject;
            return dataShadow.getOriginal().getPrimaryFile();
        }
        return dataObject.getPrimaryFile();
    }

dzsessona commented 11 years ago

Hi markiewb. Your code works fine, but there is a problem: the action is enabled with the cookie DataObject. At the moment i believe you can enable disable the action choosing one of:

-) Project -) Open cookie -) EditCookie -) EditorCookie -) DataObject

So the action in that case would be disabled. One thing i have done though is the following: you can open favourite root folders by using the "open terminal (or filesystem) in" ... action. I know there are a few more clicks but I think it could work, Here is a screenshot of what i have done, tell me what you think. Or if you know how to write a custom action enabler....

projects

markiewb commented 11 years ago

Or if you know how to write a custom action enabler....

Alternative a) Use a CookieAction

See http://netbeans.dzone.com/news/which-netbeans-platform-action . Especially the section "Deprecated? Not Quite"
See http://benkiew.wordpress.com/2013/01/06/netbeans-ide-7-3-how-to-extend-the-context-menu-of-the-members-and-hierarchy-view/ (see enabled() and cookieClasses())

Alternative b) Extend from AbstractAction

See http://benkiew.wordpress.com/2012/12/28/netbeans-how-to-create-a-context-aware-action-with-an-icon-for-the-context-menu/ (within isEnabled() you can check for whatever you want. For example: Check for FileObj, then for DataObject, then fallback to other things)

I know this will be some refactoring within your code, but afterwards it is more flexible then. I hope that will help you.

markiewb commented 11 years ago

Do you need any support?

dzsessona commented 11 years ago

Hi markieweb, thank you! Well, if you want, i cannot find not even 5 minutes to work on it. Hopefully next week i will not be so busy.

markiewb commented 11 years ago

@kinkadzs : Any news here?

markiewb commented 10 years ago

@kinkadzs : How about merging my pull request? Did you managed to review the patch? A new version for the plugin center would be very nice.