search

dzurikmiroslav / esp32-evse

ESP32 EVSE firmware
GNU General Public License v3.0
79 stars 30 forks source link

a few rather small changes in evse.c #66

Closed taliesin closed 1 month ago

taliesin commented 2 months ago

Description:

I tried to reduce the number of different condition tests for the state changes, in the context of charging_allowed() and ended up with quite a few lines less in the code. Please review my change of the AC-relay turn off condition in C1 and D1, in case of !available the behavior will change, i.e. the relay will turn off immediately instead of waiting for the timeout in C1 or D1. From my perspective this is valid, but please check.

Related issue (if applicable): fixes # (issue)

Checklist:

NOTE: The code change must pass CI. Your PR cannot be merged unless CI pass

taliesin commented 1 month ago

I'll close this one, as the master branch has diverged quite a bit and [a45b97c] and [9e0c703] have found their way in the code already. Need to catch-up on the code again, too busy currently.