search

dzwdz / chat_heads

Mozilla Public License 2.0
57 stars 34 forks source link

[1.18.2][Compatibility] not compatible with [Item Sharing] module (in Quark) #28

Closed qznfbnj closed 2 years ago

qznfbnj commented 2 years ago
  1. Install Forge-1.18.2-40.1.52
  2. Install chat_heads-0.6.0-forge-1.18.1 alongside Quark-3.2-358
  3. Startup and crash

If comment out "client.ChatComponentMixin" in quark.mixins.json, game can run normally. But 'Render Items In Chat' function in 'Item Sharing' module will render nothing. chatheads-quark Because I can't figure out whose fault it is, I will submit to another at the same time: https://github.com/VazkiiMods/Quark/issues/3797.

Useless stuff: Latest.log Debug.log Crash Report

Fourmisain commented 2 years ago

Hm... That's weird, it works just fine on my end and I'm using the exact same versions...? ok

This might be a Mixin priority thing where it works when one applies before the other but not the other way around.

Fourmisain commented 2 years ago

Ah yeah, I see what's happening. Quark redirects the Font.drawShadow call that Chat Heads tries to target. Actually, there is no reason for Quark to redirect the method, I think I'm gonna PR a fix.

Fourmisain commented 2 years ago

Ended up fixing it in Chat Heads afterall (it's a simple change on our side and fixing it in Quark would be uglier).

The CurseForge release should be approved soon!