search

dzwdz / chat_heads

Mozilla Public License 2.0
57 stars 34 forks source link

unable use in 1.19.4 #78

Closed sweetapple-233 closed 11 months ago

sweetapple-233 commented 11 months ago

forge version : 45.2.6 chatheads : 0.10.25[Forge] only with this mod still trash,there's crash report : https://pastebin.com/hPf1A10v edit--------------------------------------------- oops. trash should be crash.sorry about that

Fourmisain commented 11 months ago

Can reproduce, gonna have to check it out it later. Might be an issue with the backport, so maybe an older version works?

Fourmisain commented 11 months ago

Found some time. This is caused by 5cee9277284d1ce1c258c87026dedcfb63282889, which was introduced in 0.10.21 for 1.19.4 and up and it affects only Forge. (Sorta makes sense that you're the first to report this, as Forge is still most active on 1.19.2.)

The targeted lambda has a different name on Forge (m_244709_). NeoForge does not have this issue since the targets are automatically remapped in the build.

This is quite annoying since I need to split up the mixins between Fabric/NeoForge and Forge now. Forge always needing that special treatment, I'm considering dropping support for it once 1.21 comes around.

New releases hopefully soon!

sweetapple-233 commented 11 months ago

Found some time. This is caused by 5cee927, which was introduced in 0.10.21 for 1.19.4 and up and it affects only Forge. (Sorta makes sense that you're the first to report this, as Forge is still most active on 1.19.2.)

The targeted lambda has a different name on Forge (m_244709_). NeoForge does not have this issue since the targets are automatically remapped in the build.

This is quite annoying since I need to split up the mixins between Fabric/NeoForge and Forge now. Forge always needing that special treatment, I'm considering dropping support for it once 1.21 comes around.

New releases hopefully soon!

Thanks for the update.BTW I still hope that forge version can keep update ;w; ,more and more api are split the gamers choice,make gamer have to give up some mod,whatever what api are using.

Fourmisain commented 11 months ago

Thanks for the update.BTW I still hope that forge version can keep update ;w; ,more and more api are split the gamers choice,make gamer have to give up some mod,whatever what api are using.

Yeah, I get that. The whole zoo of loaders, Forge, Fabric, Quilt, and now NeoForge, and the resulting split is no fun time for gamers. It's the reason I ported many of my mods and Chat Heads to Forge in the first place, despite liking Fabric tons more on the development side. Architectury made cross-development a lot easier, though with some drawbacks as well (e.g. regular Fabric/Forge projects not being able to depend on Architectury projects easily, which can hinder mod compatibility).

One of the reasons I'm considering dropping Forge is that there seems to be a big push towards NeoForge from mod developers. There's e.g. a running poll in the Architectury discord. One of the questions is "If you are a mod developer (...) what modloaders do you plan to support for the future versions?" and it currently has a 3:1 majority for NeoForge vs Forge. That might mean 3/4 of developers plan to stop supporting Forge for future Minecraft versions. It could also mean that Architectury might not support Forge in the future either. One always have to take statements like that with a grain of salt, of course. It's just one poll in one discord with "only" a few hundred votes.

In a sense though, if everyone pushes towards one direction, it might actually help decrease the divide.

It's still to early to decide anything, so Forge probably won't go anywhere, for now.

P.S. I think I got a working build now, gonna need to do some backports and testing.

Fourmisain commented 11 months ago

Phew, I don't think I ever took that long for backporting and testing. 12 new releases pushed!