Should check for tagging in INSTALLED_APPS, not just test import

dzxs / django-photologue

Automatically exported from code.google.com/p/django-photologue

BSD 3-Clause "New" or "Revised" License

0 stars 0 forks source link

Should check for tagging in INSTALLED_APPS, not just test import #140

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago

I have the django-tagging app on my pythonpath, but I do not wish to use it
in the project I'm using photologue in. Photologue tests for its presence
via an import instruction rather than django.conf.settings.INSTALLED_APPS.
The latter should be used instead so that the user can choose whether to
use tagging or not in their project!

Original issue reported on code.google.com by DrMe...@gmail.com on 17 Oct 2009 at 5:01

GoogleCodeExporter commented 9 years ago

Good point, that would be useful. I've attached a patch that I believe should 
do the
trick.

Original comment by xxf4n...@gmail.com on 20 Oct 2009 at 8:37

Attachments:

models.diff

GoogleCodeExporter commented 9 years ago

Original comment by justin.d...@gmail.com on 5 Nov 2009 at 6:39

Changed state: Accepted
Added labels: Type-Enhancement

GoogleCodeExporter commented 9 years ago

I've attached a patch as well, as I believe that the previous diff would have 
failed to create the fall-back TagField if 'tagging' was not in INSTALLED_APPS.

Original comment by mail%mattaustin.me.uk@gtempaccount.com on 12 Aug 2010 at 3:20

Attachments:

tagging_check.patch